jeremy/joeblox
1
Fork 0
Code Issues Pull requests 2 Releases Activity

world: added grass and sky #5

Merged
jeremy merged 6 commits from devel into master 2026-01-27 10:52:35 +13:00
Conversation 1 Commits 6 Files changed 6 +111 -22
simon commented 2026-01-22 21:53:08 +13:00
Collaborator
Copy link

Just added a simple sky and grass

Just added a simple sky and grass
simon added 1 commit 2026-01-22 21:53:08 +13:00
simon force-pushed devel from 9a0ff2dd1b to ce21d1c83f 2026-01-22 22:03:53 +13:00 Compare
simon force-pushed devel from ce21d1c83f to a89b4ad168 2026-01-22 22:05:21 +13:00 Compare
simon force-pushed devel from a89b4ad168 to 0a384e32c8 2026-01-22 22:06:46 +13:00 Compare
jeremy force-pushed devel from 0a384e32c8 to 1017920ee0 2026-01-22 22:12:33 +13:00 Compare
simon added 1 commit 2026-01-23 08:04:48 +13:00
simon added 1 commit 2026-01-23 09:20:01 +13:00
simon force-pushed devel from 9f85c39b02 to e5c1280dd9 2026-01-23 09:41:41 +13:00 Compare
simon added 1 commit 2026-01-24 17:16:47 +13:00
simon added 1 commit 2026-01-25 19:14:01 +13:00
jeremy force-pushed devel from 35e193d74f to 05c8dbca70 2026-01-25 19:49:38 +13:00 Compare
jeremy force-pushed devel from 05c8dbca70 to 1cdd89ce5e 2026-01-25 19:51:20 +13:00 Compare
jeremy force-pushed devel from 1cdd89ce5e to 4e8b397948 2026-01-25 20:02:15 +13:00 Compare
simon force-pushed devel from 4e8b397948 to 1fd43ac5f9 2026-01-25 20:08:02 +13:00 Compare
simon added 2 commits 2026-01-25 20:10:33 +13:00
simon force-pushed devel from 350e17656b to f93e3ff992 2026-01-25 20:12:59 +13:00 Compare
jeremy force-pushed devel from f93e3ff992 to cf14e5d398 2026-01-25 20:14:38 +13:00 Compare
simon added 1 commit 2026-01-26 15:49:41 +13:00
jeremy reviewed 2026-01-26 19:50:57 +13:00
player/camera_gimbal.gd Outdated
@ -36,0 +70,4 @@
$InnerGimbal/Camera3D.position.x = $InnerGimbal/Camera3D.position.x
$InnerGimbal/Camera3D.position.y = lerp($InnerGimbal/Camera3D.position.y, float(current_zoom), zoom_speed*delta)
$InnerGimbal/Camera3D.position.z = lerp($InnerGimbal/Camera3D.position.z, float(current_zoom), zoom_speed*delta)
jeremy commented 2026-01-26 19:50:57 +13:00
Owner
Copy link

This is great work bro but these last three lines can be improved to something like this:

var p = Vector3($InnerGimbal/Camera3D.position)
p.y = lerp(p.y, float(current_zoom), zoom_speed * delta)
p.z = lerp(p.z, float(current_zoom), zoom_speed * delta)

$InnerGimbal/Camera3D.position = p

Since we instantiate p to be a copy of the Camera3D's position on the first line, we don't need to assign p.x manually. And the lines are shorter so they can fit in an editor without going over the edge 😁

Also we call lerp with p's properties instead of the long name ($InnerGimbal/...). If the path to the Camera3D changes we only need to change one reference where we define p instead of replacing the whole lot.

Also please put spaces on both sides of the asterisks 😁

This is great work bro but these last three lines can be improved to something like this: ```swift var p = Vector3($InnerGimbal/Camera3D.position) p.y = lerp(p.y, float(current_zoom), zoom_speed * delta) p.z = lerp(p.z, float(current_zoom), zoom_speed * delta) $InnerGimbal/Camera3D.position = p ``` Since we instantiate `p` to be a copy of the Camera3D's position on the first line, we don't need to assign `p.x` manually. And the lines are shorter so they can fit in an editor without going over the edge 😁 Also we call lerp with `p`'s properties instead of the long name (`$InnerGimbal/`...). If the path to the Camera3D changes we only need to change one reference where we define `p` instead of replacing the whole lot. Also please put spaces on both sides of the asterisks 😁
simon force-pushed devel from 626fc3d752 to fced905bae 2026-01-27 10:51:52 +13:00 Compare
jeremy merged commit fced905bae into master 2026-01-27 10:52:35 +13:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: jeremy/joeblox#5
No description provided.
Delete branch "devel"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?